Skip to content

Conversation

@absidue
Copy link
Member

@absidue absidue commented Aug 14, 2025

Pull Request Type

  • Composition API migration

Description

This pull request migrates the FtSelect component to the composition API.

Testing

Check that select boxes work correctly e.g. on the settings page.

Desktop

  • OS: Windows
  • OS Version: 10

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 14, 2025 17:30
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 14, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc

vue warning

VirtualBoxVM_LYDRmUQtSs

@absidue
Copy link
Member Author

absidue commented Aug 15, 2025

From the PlayerSettings migration in #7766:

You may receive some prop validation errors from Vue (technically warnings but logged as errors by Vue), they don't impact functionality and you can make them go away by altering your playback rate interval setting once.

@FreeTubeBot FreeTubeBot merged commit 69a083a into FreeTubeApp:development Aug 16, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 16, 2025
@absidue absidue deleted the ft-select-composition-api branch August 16, 2025 20:39
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 19, 2025
* development: (22 commits)
  Translated using Weblate (Persian)
  Fix show added items not working for hide videos from channels (FreeTubeApp#7854)
  Respect watch history setting when opening in an external player (FreeTubeApp#7853)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Japanese)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Romanian)
  Translated using Weblate (Estonian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Italian)
  Translated using Weblate (Czech)
  Translated using Weblate (Portuguese (Brazil))
  Migrate FtSelect to the composition API (FreeTubeApp#7847)
  Translated using Weblate (Bulgarian)
  Translated using Weblate (German)
  Translated using Weblate (Hungarian)
  Translated using Weblate (French)
  Added hide to tray on minimize option (FreeTubeApp#6915)
  Add support for parsing premiere video LockupViews (FreeTubeApp#7848)
  Bump package version from 0.23.6 to 0.23.7 (FreeTubeApp#7849)
  ...

# Conflicts:
#	src/renderer/helpers/api/local.js
caetano-dev pushed a commit to caetano-dev/FreeTube that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants