Use Array#find directly when parsing the chapters #7808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Aug 10, 2025
kommunarr
approved these changes
Aug 10, 2025
ChunkyProgrammer
approved these changes
Aug 10, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 11, 2025
* development: Translated using Weblate (Serbian) Fix selecting a new quick bookmark playlist (FreeTubeApp#7803) Migrate DistractionSettings to the composition API (FreeTubeApp#7807) Use Array#find directly when parsing the chapters (FreeTubeApp#7808) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) Translated using Weblate (Croatian) change iina name to IINA (FreeTubeApp#7773) Remove `Export Playlists For Older FreeTube Versions` (FreeTubeApp#7195) Enhancement: Add fast forward and rewind pop up to video player (FreeTubeApp#7729) Fix "more" button from sidenav not closing (FreeTubeApp#7725) Fix handleSyncSubscriptionCache using the SYNC_PLAYLISTS IPC channel (FreeTubeApp#7756) Change Close button color to white (FreeTubeApp#7752) Migrate PlayerSettings to the composition API (FreeTubeApp#7766) Bump package version from 0.23.5 to 0.23.6 (FreeTubeApp#7794) Add shorts player parameters to help with 403s (FreeTubeApp#7763) Translated using Weblate (Norwegian Bokmål) Bump the stylelint group with 2 updates (FreeTubeApp#7779) Bump tmp from 0.2.1 to 0.2.4 (FreeTubeApp#7790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
YouTube.js' ObservableArray#get is a wrapper around Array#find but with object comparisions, so using Array#find directly is faster.
Testing
Check that chapters still appear in the chapters box on a video with chapters such as https://youtu.be/jNQXAC9IVRw.
Desktop