Avoid logging an error when a player cache entry does not exist #6640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Jan 26, 2025
kommunarr
approved these changes
Jan 26, 2025
ChunkyProgrammer
approved these changes
Jan 27, 2025
github-actions
bot
removed
the
PR: waiting for review
SudharakaP
pushed a commit
to SudharakaP/FreeTube
that referenced
this pull request
Jan 28, 2025
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jan 29, 2025
* development: (35 commits) Shrink mime-db even further (FreeTubeApp#6659) * Update play next recommended video setting to be "by default" (FreeTubeApp#6400) Miscellaneous performance improvements (FreeTubeApp#6658) Bump stylelint in the stylelint group across 1 directory (FreeTubeApp#6660) Bump the stylelint group across 1 directory with 4 updates (FreeTubeApp#6605) Fixes FreeTubeApp#5476: Adjusted z-index for tooltips to avoid overlapping with bars (FreeTubeApp#6656) Bump shaka-player from 4.12.8 to 4.13.0 (FreeTubeApp#6649) Migrate ProfileSettings, FtProfileBubble and FtProfileEdit to the composition API (FreeTubeApp#6639) Translated using Weblate (Arabic) Bump the eslint group with 4 updates (FreeTubeApp#6645) Bump bgutils-js from 3.1.2 to 3.1.3 (FreeTubeApp#6650) Translated using Weblate (Arabic) Translated using Weblate (Arabic) Bump electron from 34.0.0 to 34.0.1 (FreeTubeApp#6648) Bump lefthook from 1.10.9 to 1.10.10 (FreeTubeApp#6647) Bump the babel group with 2 updates (FreeTubeApp#6644) Translated using Weblate (Arabic) Avoid logging an error when a player cache entry does not exist (FreeTubeApp#6640) Move saving screenshots to the default folder to an IPC call (FreeTubeApp#6636) Replace rimraf dev dependency with clean script (FreeTubeApp#6638) ...
OothecaPickle
pushed a commit
to OothecaPickle/FreeTube
that referenced
this pull request
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid logging an error when a player cache entry does not exist
Pull Request Type
Description
When a player cache entry doesn't exist, we currently log Node.js'
ENOENTerror, which just means "error no entry", which will occur every now and then, as the player IDs change when YouTube updates their player JavaScript. On various occasions users have seen these error messages and thought they meant that something was wrong, so lets not log them to avoid confusing users.Desktop