Clean up more unused strings #6529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
previously approved these changes
Jan 8, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jan 8, 2025
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Member
|
We have to approve fast on this one otherwise Weblate commits will cause conflicts |
Member
|
Book a time to approve (or launch a nuke POV: Incoming Weblate commits |
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and PikachuEXE
via
c70d1c3
absidue
force-pushed
the
cleanup-strings
branch
from
3a28ca7 to
c70d1c3
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Jan 8, 2025
ChunkyProgrammer
requested review from
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
kommunarr
approved these changes
Jan 8, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 9, 2025
github-actions
bot
removed
the
PR: waiting for review
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up more unused strings
Pull Request Type
Related issue
Description
Removes 8730 bytes from the
dist/static/localesdirectory after runningyarn pack:renderer. Not as effective as last time, as we added a lot of strings since the last release (48 in one pull request alone) but still better than nothing.Unused strings that were removed:
Global.Input Tags.Length Requirement->Trimmed input must be at least N characters longPlaylist {playlistName} is the new quick bookmark playlist.->This playlist is now used for quick bookmarkandThis playlist is now used for quick bookmark instead of {oldPlaylistName}. Click here to undoVideo.Sort By.*->Channel.Videos.Sort Types.*Settings.Data Settings.Select Import Type-> We automatically detect it based on the file extension and contentsVideo.'Chat is disabled or the Live Stream has ended.'->Video.'Live Chat is unavailable for this stream. It may have been disabled by the uploader.'Subscriptions.Latest SubscriptionsSubscriptions.'Getting Subscriptions. Please wait.'Settings.Password Dialog.Password IncorrectSettings.Password Dialog.Unlock-> We automatically unlock when the password is correctProfile.Profile could not be foundComments.Show Comments->Comments.Click to View CommentsVideo.Premieres on->Video.PremieresComments.No more comments available-> We used to let the user click the load more button even when we knew there were no more comments available, now we hide the button instead.Unused strings that no longer existed in en-US that were removed:
Subscriptions.Refresh Subscriptions->Feed.Refresh FeedVideo.Premieres inSettings.Player Settings.Playlist Next Video IntervalSubscriptions.'Getting Subscriptions. Please wait.'Desktop