Skip to content

Add missing release builds #6415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FreeTubeBot merged 1 commit into from
Dec 20, 2024
Merged

Add missing release builds #6415

FreeTubeBot merged 1 commit into from
Dec 20, 2024

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 19, 2024 •
edited
Loading

Add missing release builds

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#6157

Description

This PR adds the following release builds:

  • AppImage ARMv7l
  • AppImage ARM64
  • Alpine .apk x64
  • Alpine .apk ARMv7l
  • Alpine .apk ARM64
  • Pacman .pacman x64

Testing

As this is a release workflow im not sure how to properly test it. This should just work out of the box. Almost everything could be taken over from the nightly build workflow. The only thing im worried about is the asset_content_type for the Pacman build, that was the only real thing i had to figure out as there were varying answers online.

Additional context

This journey is only part one of many PR's (well i hope not too many) to come on this subject and has been triggered by @PikachuEXE PR. I noticed that we had more nightly builds than release builds so i went on a quest to provide these missing builds to users so they wouldnt need to use the nightly builds.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 19, 2024 22:33
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 19, 2024
@PikachuEXE
Copy link
Member

PikachuEXE commented Dec 19, 2024 •
edited
Loading

Can we put linux entries together (instead of some below MacOS entries
Also no entries for Upload .rpm?

(Compared with https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 19, 2024 •
edited
Loading

Can we put linux entries together (instead of some below MacOS entries

I would like to do the grouping of the builds in a separate PR for both the release and build workflow as there is some randomness going on in general

Also no entries for Upload .rpm? (Compared with https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml

I added no .rpm because the release workflow already provides the same ones as the build workflow so im unsure what you mean by this.

@PikachuEXE
Copy link
Member

PikachuEXE commented Dec 19, 2024

.rpm is above windows one I missed it...

@FreeTubeBot FreeTubeBot merged commit 3a0f12b into FreeTubeApp:development Dec 20, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 20, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the add-missing-builds branch December 20, 2024 11:04
Merged
4 tasks
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Dec 21, 2024
@PikachuEXE
Merge branch 'development' into custom-builds/tmp
3fe78d0 
* development: (57 commits)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Serbian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Estonian)
  Translated using Weblate (Czech)
  Translated using Weblate (French)
  add missing release builds (FreeTubeApp#6415)
  Translated using Weblate (Serbian)
  Translated using Weblate (German)
  Translated using Weblate (Italian)
  Translated using Weblate (Chinese (Traditional Han script))
  apply overflow menu text color change only to overflow menu (not to stats button) (FreeTubeApp#6406)
  Make a single IPC call for the navigation history (FreeTubeApp#6366)
  Added buttons to hide hidden channels/text (FreeTubeApp#6156)
  Translated using Weblate (Serbian)
  Translated using Weblate (Afrikaans)
  Translated using Weblate (Afrikaans)
  Translated using Weblate (Vietnamese)
  Translated using Weblate (Afrikaans)
  ...
Merged
1 task
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc
add missing release builds (FreeTubeApp#6415)
293b312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@kommunarr kommunarr kommunarr approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @kommunarr @FreeTubeBot