Skip to content

Filter out unsupported watch page only mixes from search results #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FreeTubeBot merged 1 commit into from
Dec 5, 2024
Merged

Filter out unsupported watch page only mixes from search results #6244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/renderer/helpers/api/local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,7 @@ function handleSearchResponse(response) {
return item.type === 'Video' || item.type === 'Channel' || item.type === 'Playlist' || item.type === 'HashtagTile' || item.type === 'Movie' || item.type === 'LockupView'
})
.map((item) => parseListItem(item))
.filter((item) => item)

return {
results,
Expand Down Expand Up @@ -1050,6 +1051,14 @@ function parseLockupView(lockupView, channelId = undefined, channelName = undefi
const thumbnailOverlayBadgeView = lockupView.content_image.primary_thumbnail.overlays
.find(overlay => overlay.is(YTNodes.ThumbnailOverlayBadgeView))

const playlistId = lockupView.content_id

// Filter out mixes without playlist pages (we don't support watch page-only mixes)
// https://wiki.archiveteam.org/index.php/YouTube/Technical_details#Playlists
if (playlistId.startsWith('RD') && !playlistId.startsWith('RDCL')) {
return null
}

const maybeChannelText = lockupView.metadata?.metadata?.metadata_rows?.[0]?.metadata_parts?.[0]?.text

if (maybeChannelText && maybeChannelText.endpoint?.metadata.page_type === 'WEB_PAGE_TYPE_CHANNEL') {
Expand All @@ -1060,7 +1069,7 @@ function parseLockupView(lockupView, channelId = undefined, channelName = undefi
return {
type: 'playlist',
dataSource: 'local',
playlistId: lockupView.content_id,
playlistId,
title: lockupView.metadata.title.text,
thumbnail: lockupView.content_image.primary_thumbnail.image[0].url,
channelName,
Expand All @@ -1070,6 +1079,7 @@ function parseLockupView(lockupView, channelId = undefined, channelName = undefi
}
default:
console.warn(`Unknown lockup content type: ${lockupView.content_type}`, lockupView)
return null
}
}

Expand Down
Loading