Fix shortcut for macOS setting shortcut in video page #6054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
PikachuEXE
commented
Nov 1, 2024
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
absidue
approved these changes
Nov 1, 2024
kommunarr
approved these changes
Nov 1, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 2, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 4, 2024
* development: (153 commits) Migrate FtTimestampCatcher to the composition API (FreeTubeApp#6064) Translated using Weblate (Polish) Added functionality to export a single playlist (FreeTubeApp#5779) Fix video player displaying a vertical scrollbar when context menu outside player container (FreeTubeApp#6075) Fix use of deprecated Invidious route on the videos subscription tab (FreeTubeApp#6057) Apply active FreeTube theme to shaka-player menus (FreeTubeApp#5986) Bump sass from 1.80.4 to 1.80.6 (FreeTubeApp#6071) Bump mini-css-extract-plugin from 2.9.1 to 2.9.2 (FreeTubeApp#6068) Translated using Weblate (Vietnamese) Bump webpack from 5.95.0 to 5.96.1 (FreeTubeApp#6069) Translated using Weblate (Vietnamese) Bump sass-loader from 16.0.2 to 16.0.3 (FreeTubeApp#6070) Bump lefthook from 1.8.1 to 1.8.2 (FreeTubeApp#6067) Bump the eslint group with 2 updates (FreeTubeApp#6066) Bump youtubei.js from 11.0.0 to 11.0.1 (FreeTubeApp#6072) Migrate PasswordSettings and PasswordDialog to the composition API (FreeTubeApp#6036) Add some missing jsdoc comments, add jsdoc eslint plugin (FreeTubeApp#6048) Fix shortcut for macOS setting shortcut in video page (FreeTubeApp#6054) Use decodingInfo's powerEfficient property when picking streams (FreeTubeApp#6061) Translated using Weblate (Afrikaans) ...
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
* ! Fix shortcut for macOS setting shortcut in video page * Update src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
* ! Fix shortcut for macOS setting shortcut in video page * Update src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
#5948 (comment)
Description
On video page
⌘+,not opening settings page and this PR fixes itScreenshots
Testing
,should work like before⌘+,should open settings pageDesktop
Additional context