Invidious API: Add support for auto-dubbed audio tracks #5943
Conversation
absidue
force-pushed
the
auto-dubbed-audio
branch
from
50ec800 to
fb5af1e
Compare
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Isnt this labeling a bit weird? Also it doesnt look to be sorted a-z?
VirtualBoxVM_csM09iqsJ6.mp4
|
Pretty sure we've never done any sorting on the audio tracks on either API, we just display them in the order that they came in the API response. As for the labels I can force it to always use the |
Ah okay good to know. Please disregard my comment.
Yes lets do that for the sake of uniformity |
|
Updated the display names to always be in the |
github-actions
bot
removed
the
PR: waiting for review
…5943) * Invidious API: Add support for auto-dubbed audio tracks * Use the standard display name format
|
Is there a timeframe we could expect the update with this to be out by? |
|
@VaelophisNyx No eta |
…5943) * Invidious API: Add support for auto-dubbed audio tracks * Use the standard display name format
6 participants
Invidious API: Add support for auto-dubbed audio tracks
Pull Request Type
Related issue
LuanRT/YouTube.js#786
Description
YouTube has added a feature for uploaders to tell YouTube to automatically generate dubbed audio tracks for their videos. Support for the local API is handled in the linked YouTube.js pull request, this pull request implements it for the Invidious backend, as we handle multiple audio tracks support for Invidious in the FreeTube code (because Invidious doesn't support them itself yet).
Testing
Check that the player selects the original audio track by default and that you can use some of the other audio tracks.
Test video: https://youtu.be/snZ9w5xc_ic (thanks to the users in the Invidious Matrix chat for mentioning a channel that has those types of audio tracks)
Desktop