Local API: Handle new shorts node #5679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Member
|
New version has been released! |
absidue
force-pushed
the
shorts-lockup-view
branch
from
ef956d1 to
96d2741
Compare
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
PR: dependencies
ChunkyProgrammer
approved these changes
Sep 20, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 20, 2024
PikachuEXE
approved these changes
Sep 21, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 21, 2024
* development: Fix video start time handling (FreeTubeApp#5719) Local API: Handle new shorts node (FreeTubeApp#5679) Update subscription cache when subscribing from the channel page (FreeTubeApp#5717) Translated using Weblate (English (United Kingdom)) Implement persistent subscription cache (FreeTubeApp#5185) Translated using Weblate (Belarusian) Bump npm-run-all2 from 6.2.2 to 6.2.3 (FreeTubeApp#5708) Translated using Weblate (Swedish) Bump shaka-player from 4.11.1 to 4.11.3 (FreeTubeApp#5707) Translated using Weblate (Persian) v Downgrade electron-builder 25.x > 24.x (FreeTubeApp#5712) Translated using Weblate (Persian) Translated using Weblate (Persian) # Conflicts: # src/renderer/views/Channel/Channel.js # src/renderer/views/Channel/Channel.vue
Member
Author
|
That comment was nothing to do with a new version of FreeTube, but about the fact that this pull request relied on changes on the YouTube.js side and that a YouTube.js update with those changes had been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local API: Handle new shorts node
Pull Request Type
Related issue
Description
YouTube is running an A/B test to replace
ReelItems withShortsLockupViews. This pull request adds support for that new node, which fixes the shorts tab on channels being empty and playlists containing only shorts throwing an error.Testing
Channel with shorts: https://www.youtube.com/@gibiasmr
Playlist containing only shorts: https://www.youtube.com/playlist?list=UUSHE6acMV3m35znLcf0JGNn7Q
Desktop