Fix incorrect/translated placeholders in locale files #5628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Sep 1, 2024
PikachuEXE
requested changes
Sep 2, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
absidue
force-pushed
the
fix-templates
branch
from
79e6f71 to
d20c584
Compare
absidue
added
PR: waiting for review
PikachuEXE
approved these changes
Sep 4, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 4, 2024
ChunkyProgrammer
approved these changes
Sep 4, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 8, 2024
* development: (21 commits) Fix playback of VOD/non-live videos with Invidious (FreeTubeApp#5654) Translated using Weblate (Bulgarian) Translated using Weblate (Japanese) Translated using Weblate (Bulgarian) Specify locale for strings that may differ from the chosen display locale (FreeTubeApp#5624) Added translation using Weblate (Afrikaans) Remove "Force Local Backend for Legacy Formats" setting (FreeTubeApp#5650) Change the hls manifest type to match the parser name shaka player registers (FreeTubeApp#5648) Fix incorrect/translated placeholders in locale files (FreeTubeApp#5628) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Turkish) Translated using Weblate (Czech) Translated using Weblate (Japanese) Translated using Weblate (French) Translated using Weblate (Japanese) Translated using Weblate (Hungarian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Chinese (Traditional Han script)) Translated using Weblate (Polish) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect/translated placeholders in locale files
Pull Request Type
Related issue
Description
Unfortunately some translators have translated the placeholders in strings, which means that FreeTube won't be able to replace them. This pull request fixes all the strings that were mentioned in the linked issue, I have not checked any other ones.
Additional context
Looks like weblate has a check for incorrect vue-i18n template strings https://docs.weblate.org/en/latest/user/checks.html#vue-i18n-formatting but according to the docs it's just a warning, it doesn't actually block the user from submitting a broken string, so not sure if it's worth setting up or not.