Fix Invidious API error toasts saying undefined #5380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Jul 9, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 9, 2024
PikachuEXE
approved these changes
Jul 9, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 10, 2024
* development: Fix Invidious API error toasts saying undefined (FreeTubeApp#5380) Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376)
6 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 11, 2024
* shaka-migration: Truncate long video titles to the screen width in the full screen overlay ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384) Fix Invidious API error toasts saying undefined (FreeTubeApp#5380) Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376)
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 16, 2024
…rrent * feature/history-sensitive-search: (60 commits) * Implement case sensitive search in history $ Refactor a bit first Bump rimraf from 5.0.8 to 6.0.1 (FreeTubeApp#5412) Translated using Weblate (Indonesian) Bump the babel group across 1 directory with 3 updates (FreeTubeApp#5419) Bump sass from 1.77.6 to 1.77.8 (FreeTubeApp#5413) Bump webpack from 5.92.1 to 5.93.0 (FreeTubeApp#5414) Bump lefthook from 1.7.1 to 1.7.2 (FreeTubeApp#5415) Bump electron from 31.1.0 to 31.2.0 (FreeTubeApp#5416) Fix about page not reacting to locale changes (FreeTubeApp#5393) Delete .github/workflows/report.yml (FreeTubeApp#5395) Bump version number to v0.21.1 Fix Invidious DASH manifest generation (FreeTubeApp#5387) ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384) Fix Invidious API error toasts saying undefined (FreeTubeApp#5380) Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376) Bump eslint-plugin-vue from 9.26.0 to 9.27.0 in the eslint group (FreeTubeApp#5371) Bump rimraf from 5.0.7 to 5.0.8 (FreeTubeApp#5373) Bump npm-run-all2 from 6.2.0 to 6.2.2 (FreeTubeApp#5374) Bump marked from 13.0.1 to 13.0.2 (FreeTubeApp#5375) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 19, 2024
* development: (59 commits) Bump the stylelint group with 2 updates (FreeTubeApp#5411) Bump rimraf from 5.0.8 to 6.0.1 (FreeTubeApp#5412) Translated using Weblate (Indonesian) Bump the babel group across 1 directory with 3 updates (FreeTubeApp#5419) Bump sass from 1.77.6 to 1.77.8 (FreeTubeApp#5413) Bump webpack from 5.92.1 to 5.93.0 (FreeTubeApp#5414) Bump lefthook from 1.7.1 to 1.7.2 (FreeTubeApp#5415) Bump electron from 31.1.0 to 31.2.0 (FreeTubeApp#5416) Fix about page not reacting to locale changes (FreeTubeApp#5393) Delete .github/workflows/report.yml (FreeTubeApp#5395) Bump version number to v0.21.1 Fix Invidious DASH manifest generation (FreeTubeApp#5387) ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384) Fix Invidious API error toasts saying undefined (FreeTubeApp#5380) Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376) Bump eslint-plugin-vue from 9.26.0 to 9.27.0 in the eslint group (FreeTubeApp#5371) Bump rimraf from 5.0.7 to 5.0.8 (FreeTubeApp#5373) Bump npm-run-all2 from 6.2.0 to 6.2.2 (FreeTubeApp#5374) Bump marked from 13.0.1 to 13.0.2 (FreeTubeApp#5375) Translated using Weblate (Portuguese (Brazil)) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 19, 2024
* development: (78 commits) Bump the stylelint group with 2 updates (FreeTubeApp#5411) Bump rimraf from 5.0.8 to 6.0.1 (FreeTubeApp#5412) Translated using Weblate (Indonesian) Bump the babel group across 1 directory with 3 updates (FreeTubeApp#5419) Bump sass from 1.77.6 to 1.77.8 (FreeTubeApp#5413) Bump webpack from 5.92.1 to 5.93.0 (FreeTubeApp#5414) Bump lefthook from 1.7.1 to 1.7.2 (FreeTubeApp#5415) Bump electron from 31.1.0 to 31.2.0 (FreeTubeApp#5416) Fix about page not reacting to locale changes (FreeTubeApp#5393) Delete .github/workflows/report.yml (FreeTubeApp#5395) Bump version number to v0.21.1 Fix Invidious DASH manifest generation (FreeTubeApp#5387) ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384) Fix Invidious API error toasts saying undefined (FreeTubeApp#5380) Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376) Bump eslint-plugin-vue from 9.26.0 to 9.27.0 in the eslint group (FreeTubeApp#5371) Bump rimraf from 5.0.7 to 5.0.8 (FreeTubeApp#5373) Bump npm-run-all2 from 6.2.0 to 6.2.2 (FreeTubeApp#5374) Bump marked from 13.0.1 to 13.0.2 (FreeTubeApp#5375) Translated using Weblate (Portuguese (Brazil)) ... # Conflicts: # src/renderer/components/side-nav/side-nav.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Invidious API error toasts saying undefined
Pull Request Type
Description
Fixes some of the Invidious error handlers trying to access the non-existent
.responseTextproperty, which resulted it in displaying and copyingundefinedinstead of the actual error message. Looks like we haven't changed those handlers since we switched away from jquery, as theresponseTextfield was a jquery thing 😬. Now all Invidious API error toasts should show the actual error message, some of them were already doing it correctly.Desktop