Dearrow: check for 204 error instead of 404 #5259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 12, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
MarmadileManteater,
PikachuEXE,
absidue and
kommunarr
kommunarr
approved these changes
Jun 12, 2024
absidue
approved these changes
Jun 12, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 13, 2024
* development: (60 commits) check for 204 error (FreeTubeApp#5259) Translated using Weblate (Turkish) ! Fix error when fetching deleted comment replies in local API (FreeTubeApp#5255) Optical enhancement - Improved spacing on the about page FreeTubeApp#5210 (FreeTubeApp#5257) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (German) Update playlist page to add remove duplicate videos button for user playlists (FreeTubeApp#5191) Respect playlist sort order in `watch-video-playlist` (FreeTubeApp#5013) Translated using Weblate (Serbian) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Arabic) Translated using Weblate (Polish) Translated using Weblate (Italian) Translated using Weblate (Turkish) Translated using Weblate (Croatian) Translated using Weblate (Dutch) Translated using Weblate (Spanish) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dearrow: check for 204 error instead of 404
Pull Request Type
Related issue
closes #5031
Description
Dearrow switched from returning error code 400 to 204 here: ajayyy/DeArrowThumbnailCache@6d6ffab
Testing
Desktop