Add missing IPC channel constants #5216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
absidue
force-pushed
the
ipc-channel-constants
branch
from
f680a6b to
4e8fbf6
Compare
Collaborator
|
I am unable to test |
PikachuEXE
approved these changes
Jun 3, 2024
Collaborator
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Show / Hide Video Statistics works when visible: true
Not related to this PR
kommunarr
approved these changes
Jun 3, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 3, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 5, 2024
* development: Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (French) Translated using Weblate (Spanish) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Spanish) Make adding duplicate disabled by default (FreeTubeApp#5044) Switch settings sections and form elements to created lifecycle hook (FreeTubeApp#5224) Translated using Weblate (French) Translated using Weblate (Estonian) Bump sass from 1.77.2 to 1.77.4 (FreeTubeApp#5222) Bump lefthook from 1.6.13 to 1.6.15 (FreeTubeApp#5223) Bump the eslint group with 2 updates (FreeTubeApp#5218) Bump electron from 30.0.8 to 30.0.9 (FreeTubeApp#5221) Bump swiper from 11.1.3 to 11.1.4 (FreeTubeApp#5220) Bump stylelint from 16.6.0 to 16.6.1 in the stylelint group (FreeTubeApp#5219) Add missing IPC channel constants (FreeTubeApp#5216)
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 5, 2024
* feature/subscription-cache: ! Rename subscriptions to subscription cache & fix outdated mutation reference Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (French) Translated using Weblate (Spanish) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Spanish) Make adding duplicate disabled by default (FreeTubeApp#5044) Switch settings sections and form elements to created lifecycle hook (FreeTubeApp#5224) Translated using Weblate (French) Translated using Weblate (Estonian) Bump sass from 1.77.2 to 1.77.4 (FreeTubeApp#5222) Bump lefthook from 1.6.13 to 1.6.15 (FreeTubeApp#5223) Bump the eslint group with 2 updates (FreeTubeApp#5218) Bump electron from 30.0.8 to 30.0.9 (FreeTubeApp#5221) Bump swiper from 11.1.3 to 11.1.4 (FreeTubeApp#5220) Bump stylelint from 16.6.0 to 16.6.1 in the stylelint group (FreeTubeApp#5219) Add missing IPC channel constants (FreeTubeApp#5216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing IPC channel constants
Pull Request Type
Description
For some IPC calls we were specifying the name in-place, this pull request creates constants for those cases. Having all of the IPC channel names listed in one place, gives us a better overview, gives us auto-complete and reduces the chance of something breaking because of a typo. Also makes it easier to avoid duplicate or conflicting names.
Testing
As this pull request doesn't touch any functionality, please check this pull request for typos instead.
Desktop