Remove unused database compacting IPC channel #5212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 2, 2024
kommunarr
approved these changes
Jun 2, 2024
PikachuEXE
approved these changes
Jun 3, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 3, 2024
* development: (36 commits) Remove unused database compacting IPC channel (FreeTubeApp#5212) Translated using Weblate (Hungarian) Translated using Weblate (Portuguese) Translated using Weblate (Finnish) Compressed Images (FreeTubeApp#5209) Cleanup unused channel hiding code in ft-list-video-numbered (FreeTubeApp#5208) Translated using Weblate (Serbian) Hide recommendations from the Watch component, instead of hiding itself (FreeTubeApp#5203) Consolidate clear subscriptions cache into one mutation (FreeTubeApp#5202) Translated using Weblate (Spanish) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Polish) Translated using Weblate (Turkish) Translated using Weblate (Hungarian) Translated using Weblate (Croatian) Store comment reply tokens separately to avoid reactivity (FreeTubeApp#5190) Translated using Weblate (Croatian) Translated using Weblate (German) Translated using Weblate (Czech) ... # Conflicts: # src/datastores/handlers/base.js # src/renderer/store/modules/subscriptions.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused database compacting IPC channel
Pull Request Type
Description
As we only call the methods to compact the datastores in Electron's main process, this pull request move the compaction code into the
compactAllDatastoresfunction, removes thepersistmethods in the datastores and removes the now unused IPC code.Testing
If you want you can test that the databases still get compacted when the app closes.
Desktop