Skip to content

Cache quick bookmark playlist to reduce the amount of lookups #5169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FreeTubeBot merged 1 commit into from
May 25, 2024
Merged

Cache quick bookmark playlist to reduce the amount of lookups #5169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/renderer/components/ft-list-playlist/ft-list-playlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ export default defineComponent({
quickBookmarkPlaylistId() {
return this.$store.getters.getQuickBookmarkTargetPlaylistId
},
quickBookmarkPlaylist() {
return this.$store.getters.getPlaylist(this.quickBookmarkPlaylistId)
},
markedAsQuickBookmarkTarget() {
// Only user playlists can be target
if (this.playlistId == null) { return false }
Expand Down Expand Up @@ -174,7 +171,7 @@ export default defineComponent({
},

enableQuickBookmarkForThisPlaylist: function () {
const currentQuickBookmarkTargetPlaylist = this.quickBookmarkPlaylist
const currentQuickBookmarkTargetPlaylist = this.$store.getters.getQuickBookmarkPlaylist

this.updateQuickBookmarkTargetPlaylistId(this.playlistId)
if (currentQuickBookmarkTargetPlaylist != null) {
Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/ft-list-video/ft-list-video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,8 @@ export default defineComponent({
return this.playlistIdTypePairFinal?.playlistItemId
},

quickBookmarkPlaylistId() {
return this.$store.getters.getQuickBookmarkTargetPlaylistId
},
quickBookmarkPlaylist() {
return this.$store.getters.getPlaylist(this.quickBookmarkPlaylistId)
return this.$store.getters.getQuickBookmarkPlaylist
},
isQuickBookmarkEnabled() {
return this.quickBookmarkPlaylist != null
Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/playlist-info/playlist-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,8 @@ export default defineComponent({
return !this.hideSharingActions
},

quickBookmarkPlaylistId() {
return this.$store.getters.getQuickBookmarkTargetPlaylistId
},
quickBookmarkPlaylist() {
return this.$store.getters.getPlaylist(this.quickBookmarkPlaylistId)
return this.$store.getters.getQuickBookmarkPlaylist
},
markedAsQuickBookmarkTarget() {
// Only user playlists can be target
Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/watch-video-info/watch-video-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,8 @@ export default defineComponent({
return this.$store.getters.getDefaultPlayback
},

quickBookmarkPlaylistId() {
return this.$store.getters.getQuickBookmarkTargetPlaylistId
},
quickBookmarkPlaylist() {
return this.$store.getters.getPlaylist(this.quickBookmarkPlaylistId)
return this.$store.getters.getQuickBookmarkPlaylist
},
isQuickBookmarkEnabled() {
return this.quickBookmarkPlaylist != null
Expand Down
9 changes: 9 additions & 0 deletions src/renderer/store/modules/playlists.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ const getters = {
getPlaylist: (state) => (playlistId) => {
return state.playlists.find(playlist => playlist._id === playlistId)
},
getQuickBookmarkPlaylist(state, getters) {
const playlistId = getters.getQuickBookmarkTargetPlaylistId

if (!playlistId) {
return undefined
}

return state.playlists.find((playlist) => playlist._id === playlistId)
}
}

const actions = {
Expand Down