Cache quick bookmark playlist to reduce the amount of lookups #5169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
May 24, 2024
kommunarr
approved these changes
May 24, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 25, 2024
github-actions
bot
removed
the
PR: waiting for review
4 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
May 26, 2024
* development: Fix channel sort values to show the values they are (FreeTubeApp#5162) Translated using Weblate (Russian) Translated using Weblate (French) Quick bookmark button RTL & hover fixes (FreeTubeApp#5157) Use addVideo instead of addVideos for quick bookmark button (FreeTubeApp#5168) Cache quick bookmark playlist to reduce the amount of lookups (FreeTubeApp#5169) Translated using Weblate (Arabic) Translated using Weblate (Indonesian) Fix hide/show channel in ft-list-video (FreeTubeApp#5149) # Conflicts: # src/renderer/components/ft-list-video/ft-list-video.js # src/renderer/components/watch-video-info/watch-video-info.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache quick bookmark playlist to reduce the amount of lookups
Pull Request Type
Description
The quick bookmark playlist is accessed in many places in the app, most notably inside every
ft-list-videoinstance to check if said video is in the quick bookmark playlist. Every place that needs the quick bookmark playlist currently searches for the playlist by itself, not just when it's created but any time that any playlist is updated or the quick bookmark target is updated. This pull request moves that search into a getter inside the playlist store. Getters inside the vuex store cache their result (not if you return a function though) and are lazily evaluated, just like computed properties inside a component. That means that the search only needs to be done once, per triggering change, instead of many times.I'm not expecting this improvement to be drastic enough to be noticeable without measuring tools, but it's still worth it as we are doing less work.
Testing
Add videos to and remove videos from the quick bookmark playlist, while checking that the icon still updates accordingly.
Desktop