Skip to content

Distinguish destructive action fixes #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FreeTubeBot merged 3 commits into from
May 2, 2024
Merged

Distinguish destructive action fixes #5048

FreeTubeBot merged 3 commits into from
May 2, 2024

Conversation

@kommunarr
Copy link
Collaborator

@kommunarr kommunarr commented May 2, 2024

Distinguish destructive action fixes

Pull Request Type

  • Bugfix

Related issue

#4374 (comment)

Description

  • Fixes playlist deletion not working due to checking for 'yes' rather than new value
  • Updates label to Yes, Delete for user playlist delete icon actions
  • Fixes changelog banner to use gray button for cancel

Screenshots

Screenshot_20240502_082527
Screenshot_20240502_082251

Testing

  • Test playlist deletion works
  • See playlist delete icons (Remove Watched Videos, Delete Playlist) have updated 'Yes' content and work
  • See changelog banner uses gray button for cancel (or go off screenshot)

Desktop

  • OS: OpenSUSE
  • OS Version: TW

@kommunarr kommunarr marked this pull request as ready for review May 2, 2024 13:26
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 2, 2024 13:26
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 2, 2024
@FreeTubeBot FreeTubeBot merged commit 0f81796 into FreeTubeApp:development May 2, 2024
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kommunarr @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot