Update playlist view to auto load next page for local API to workaround UX issue of useless continuation data #4519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound issue of useless continuation data
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
kommunarr
approved these changes
Jan 4, 2024
Collaborator
kommunarr
left a comment
kommunarr
left a comment
There was a problem hiding this comment.
Playlist with 100 videos: https://youtube.com/playlist?list=PLRdw3IjKY2gkl3N2yfod0la3AyhuUCq0C
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 5, 2024
absidue
approved these changes
Jan 6, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
The issue of YT returning useless continuation data fixed in #4102
But UX becomes worse especially after we have multiple playlist (copy function which complains about not fully loaded remote playlists) #4234
Description
For viewing remote playlists with local API
This PR makes FT loads when playlist video count < 100 (no change for playlist with >= 100 videos)
So that for those < 100 remote playlists
Also affects loading next page behaviour
Screenshots
Video? Lazy
You should test anyway
Testing
Press load next page to ensure no more load next page button
Desktop
Additional context