Fix playlist view on the watch page not reacting to playlist changes #3897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 19, 2023
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
LGTM
PikachuEXE
reviewed
Aug 20, 2023
| } | ||
| }, | ||
| playlistId: function (newVal, oldVal) { | ||
| if (oldVal !== newVal) { |
Member
There was a problem hiding this comment.
I don't understand this conditional...
Member
Author
There was a problem hiding this comment.
We don't want to refetch the playlist if the id is the same
Member
There was a problem hiding this comment.
It's called when value not updated too? (It's inside watch)
Member
Author
There was a problem hiding this comment.
I'm not sure, we definitely set the property every time the video changes, but i'm not sure if watch is triggered on every set or just when the value changes. We have this pattern inside watches in a few places which made me think it might get triggered for every set but i'm not sure.
Member
Author
There was a problem hiding this comment.
I can always remove the check later, if we find out that it's redundant.
ChunkyProgrammer
approved these changes
Aug 20, 2023
PikachuEXE
approved these changes
Aug 21, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* development: Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897) Bump version number to v0.19.0 Fix linting issues Translated using Weblate (Bulgarian) Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851) local API: Add support for PageHeader hashtag header (FreeTubeApp#3896) Translated using Weblate (German) Translated using Weblate (Swedish) Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895) # Conflicts: # src/renderer/components/ft-list-playlist/ft-list-playlist.vue # src/renderer/components/watch-video-playlist/watch-video-playlist.vue
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* feature/playlist-2023-05: Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897) Bump version number to v0.19.0 Fix linting issues Translated using Weblate (Bulgarian) Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851) local API: Add support for PageHeader hashtag header (FreeTubeApp#3896) Translated using Weblate (German) Translated using Weblate (Swedish) Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix playlist view on the watch page not reacting to playlist changes
Pull Request Type
Related issue
#3895 (comment)
Description
Currently the playlist view on the watch page doesn't react to the playlist changing, when you jump directly from one playlist to another one, without leaving the watch page in between.
This bug exists because unlike the other components on the watch page, the playlist view stays mounted when the video changes, this is to avoid refetching the playlist for every video in the same playlist.
Screenshots
Screenshot from the comment:
Testing
Paste the first playlist URL into the search bar, afterwards the second one, the playlist view on the watch page should update to the second playlist instead of continuing to show the first one.
playlist 1: https://www.youtube.com/watch?v=xEyR5dCQs60&list=PLa4zmfXkL4P2khNoEOGA8NEOgFwHIWGIX
playlist 2: https://www.youtube.com/watch?v=HUlR6zQjTmw&list=PLa4zmfXkL4P0UaXti2bPFpsyi3K_IE0rB