Skip to content

Fix author for album playlists on the playlist page #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FreeTubeBot merged 2 commits into from
Aug 4, 2023
Merged

Fix author for album playlists on the playlist page #3838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
405bf4d
Fix author for album playlists on the playlist page
absidue Aug 1, 2023
9dbb19f
Only show artists
absidue Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderer/components/playlist-info/playlist-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default defineComponent({
title: '',
channelThumbnail: '',
channelName: '',
channelId: '',
channelId: null,
videoCount: 0,
viewCount: 0,
lastUpdated: '',
Expand Down
11 changes: 11 additions & 0 deletions src/renderer/components/playlist-info/playlist-info.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
class="channelShareWrapper"
>
<router-link
v-if="channelId"
class="playlistChannel"
:to="`/channel/${channelId}`"
>
Expand All @@ -55,6 +56,16 @@
{{ channelName }}
</h3>
</router-link>
<div
v-else
class="playlistChannel"
>
<h3
class="channelName"
>
{{ channelName }}
</h3>
</div>

<ft-share-button
v-if="!hideSharingActions"
Expand Down
13 changes: 12 additions & 1 deletion src/renderer/views/Playlist/Playlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,17 @@ export default defineComponent({
this.isLoading = true

getLocalPlaylist(this.playlistId).then((result) => {
let channelName

if (result.info.author) {
channelName = result.info.author.name
} else {
const subtitle = result.info.subtitle.toString()

const index = subtitle.lastIndexOf('•')
channelName = subtitle.substring(0, index).trim()
}

this.infoData = {
id: this.playlistId,
title: result.info.title,
Expand All @@ -92,7 +103,7 @@ export default defineComponent({
viewCount: extractNumberFromString(result.info.views),
videoCount: extractNumberFromString(result.info.total_items),
lastUpdated: result.info.last_updated ?? '',
channelName: result.info.author?.name ?? '',
channelName,
channelThumbnail: result.info.author?.best_thumbnail?.url ?? '',
channelId: result.info.author?.id,
infoSource: 'local'
Expand Down