[Local API] Update subscription view to show live videos #3659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
ChunkyProgrammer and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
changed the title
Member
|
Scheduled Live Streams do not show up. Tested this with upcoming live streams from www.youtube.com/@live Past live streams show up |
Member
|
Update Scheduled Live Streams do seem to show up tested with www.youtube.com/@ziggosport |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 26, 2023
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
LGTM
Collaborator
Author
|
But if #3668 is accepted I rather have tabs... |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Member
|
So this can be closed? |
Collaborator
Author
|
This will be replaced by another PR (not submitted yet) with tabs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
#2852 related but this PR only changes Local API
Description
This PR makes FT to also request live tab (unless hide live stream enabled) for each channel
This means the number of requests doubles
So this should be considered during review
Screenshots
With Linus Tech Tips in a profile only
https://www.youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw
Testing
A. With live stream (
hide live streamoff = show)hide live streambrowse)B. With live stream (
hide live streamon = hide)hide live streambrowse)C. Without live stream (
hide live streamoff = show)hide live streambrowse)Desktop
Additional context
Scheduled Live Streams not tested