Themes CSS deduplication #2868
Merged
Themes CSS deduplication #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Nov 15, 2022
Member
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Is it possible to have tools to do this for us semi-auto/full-auto in the future?
ChunkyProgrammer
approved these changes
Nov 15, 2022
Member
Author
|
I can try some of the other tools that the CssMinimizerPlugin supports, currently we are using cssnano which is the default. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 15, 2022
github-actions
bot
removed
the
PR: waiting for review
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Themes CSS deduplication
Pull Request Type
Description
Just deduplicates some of the CSS rules, that way the output is 6KB smaller. You probably want to review this commit by commit, instead of looking at it all in one go.
Screenshots
Testing
Check that the colours still work, you don't need to test all of them if you don't want to.
Desktop