Skip to content

Remove the now unused jquery dependency #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PrestonN merged 1 commit into from
Oct 6, 2022
Merged

Remove the now unused jquery dependency #2682

PrestonN merged 1 commit into from
Oct 6, 2022

Conversation

@absidue
Copy link
Member

@absidue absidue commented Oct 6, 2022

Remove the now unused jquery dependency

Pull Request Type

  • Feature Implementation
  • Celebration

Related issue

closes #2360

Description

This is the last pull request in the jquery removal series.

Highlights:

  • Dropped 88kb from renderer.js output
  • Better (maybe not noticeable) performance as we are now using the native stuff directly
  • Had a chance to clean up some components
  • One less dependency

Testing

As all references to jquery are gone, webpack doesn't bundle it in anymore, so this PR doesn't break anything.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.17.1

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 6, 2022
@PrestonN PrestonN enabled auto-merge (squash) October 6, 2022 14:37
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye jay kwery

@PrestonN PrestonN merged commit f67c697 into FreeTubeApp:development Oct 6, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 6, 2022
@absidue absidue deleted the remove-jquery-dependency branch October 7, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees

No one assigned

Labels

PR: dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @PrestonN