Remove ytdl-core and yt-dash-manifest-generator #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
previously approved these changes
Jan 7, 2023
Member
|
That functionality list is long... |
Member
|
Is there a reason for not removing the proxy agents from the list? |
Member
Author
|
I did the local API page first and then forgot to remove the proxy agents from the credits page 🙈 |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 7, 2023
Member
|
At this rate all our dependencies will be removed and only we are our only bottleneck... I know that isnt possible but i am wondering how many dependencies we still can get rid of👀 |
ChunkyProgrammer
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeTubeApp/FreeTube#3035
We might want to redesign this page at some point, as it will just be YouTube.js when the local API is fully migrated.
Also we should remove videojs-vtt-thumbnails-freetube from the local API page, as that is our video.js plugin to show the thumbnails when you hover over the progress bar, both the local and Invidious APIs provide those storyboards.