Implement transport send and receive timeouts in coreHTTP #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s disabled whtn the time keeping function does not exist.
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
yourslab
reviewed
Dec 11, 2020
leegeth
reviewed
Dec 11, 2020
leegeth
reviewed
Dec 11, 2020
aggarw13
reviewed
Dec 11, 2020
aggarw13
reviewed
Dec 11, 2020
aggarw13
reviewed
Dec 11, 2020
aggarw13
reviewed
Dec 11, 2020
sarenameas
commented
Dec 11, 2020
sarenameas
commented
Dec 11, 2020
leegeth
previously approved these changes
Dec 11, 2020
leegeth
approved these changes
Dec 11, 2020
yourslab
approved these changes
Dec 11, 2020
n9wxu
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements send and receive timeouts for HTTPClient_Send() just as coreMQTT does for MQTT_ProcessLoop and MQTT_RecieveLoop did here: FreeRTOS/coreMQTT#120
This extra layer of protection allows receiving or sending data after small interrupts in the transport layer.
Before, sendHttpData() had the potential to loop forever which would be devastating in a single threaded environment.
Before, receiving the response would stop as soon as zero was returned from the transport receive. Zero was updated in the transport_interface.h file to mean "no data available right now". We want to try again, if the application desires, for a bit more robustness.