Make run script return zero on proof failure #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkhaz
force-pushed
the
kk-litani-return-zero
branch
from
91fa4f6
to
c3093c4
Compare
|
This PR is now changed to update the litani submodule rather than changing any of the build code in the proofs directory. Updated the title accordingly. |
This update ensures that final proof results get posted to GitHub even when there are proof failures.
karkhaz
force-pushed
the
kk-litani-return-zero
branch
from
c3093c4
to
c6f0666
Compare
markrtuttle
previously approved these changes
Nov 10, 2020
sarenameas
previously approved these changes
Nov 12, 2020
n9wxu
previously approved these changes
Nov 13, 2020
sarenameas
dismissed stale reviews from n9wxu, markrtuttle, and themself
The base branch was changed.
sarenameas
approved these changes
Nov 18, 2020
dan4thewin
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, litani would return a non-zero code when any proof
job failed, and the run script would throw an exception when this
happened.
This commit adds the --exit-zero-on-fail flag to the litani run-build
invocation, so that litani returns zero even if there are proof failures
(but will continue to return a non-zero exit code if there was a crash
or some other error).
This is so that CI can distinguish between proof failures (which can be
detected in the litani JSON output), and litani crashes due to bugs in
litani, inconsistent builds, or other errors.