SPICE plugin: USB redirection support + minor fixes #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sftp_client_confirm_resume` structure declaration is surrounded by `#if defined (HAVE_LIBSSH) && defined (HAVE_LIBVTE)` in the file `remmina_masterthread_exec.h`. However, its usage in the function `remmina_masterthread_exec_callback()` is only surrounded by `#ifdef HAVE_LIBSSH` in the file remmina_masterthread_exec.c. As the `remmina_sftp_client_confirm_resume()` function does not requires VTE, the test on `HAVE_LIBVTE` can be removed. Bug introduced in f765bbf.
Viewing this commit with --ignore-space-change helps a lot.
Taken from spicy's implementation.
|
Tested on Ubuntu 16.04, Fedora 23, AntergOS (arch linux), FreeBSD 10.3. Good job, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation has been taken from
spicy.Testing it on ArchLinux requires this workaround due to a bug in the latest version of the package
spice-gtk3.Could you test it on other distributions ?