Remmina Main Window Refactoring

[antenore]

This PR brings a new Remmina Main window using an header bar

[antenore]

This adhere more to the Gnome guidelines

With the Search Bar Deactivated:

With the Bar activated.

@giox069 , should we update the poll on G+ ?

[giox069]

I liked a lot the previous version with the search bar always visible on the first row. Searching, in my daily use, is done very frequently, at each connection. Hiding the search bar is not very useful: I have an extra button shown, I have to unhide it, I lose one line of space. Search, in Remmina, is not an option for me, it's daily life.

If a user does not uses search... he/she could simply ignore it ?

About the G+ poll: we still have too few users and I don't think we will be useful to make a poll now... but it's just another personal opinion. The community is slowly growing, and this is good.

[antenore]

I liked a lot the previous version with the search bar always visible on the first row. Searching, in my daily use, is done very frequently, at each connection. Hiding the search bar is not very useful: I have an extra button shown, I have to unhide it, I lose one line of space. Search, in Remmina, is not an option for me, it's daily life.

By default is already unhide, hiding the search bar is an option not the standard. So you can consider just the second screenshot.

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

Moreover consider that I've removed completely the window decoration, so you lost one line but you got a new one, so you have lost zero at the end.

I'm undecided, I let you all decide because I really don't know.

Personally I like more this last solution as it is much more "compliant" and easier to code.

[larchunix]

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

When I have suggested to center the quick connect widget I didn't realize it would be this painful. It's not worth it to spend so much effort on it.

[antenore]

Regarding the additional row I agree, but I don't have an easy and clean solution to stack it in the middle. We can just have it on the right (end) or on the left (start).

When I have suggested to center the quick connect widget I didn't realize it would be this painful. It's not worth it to spend so much effort on it.

Yes, but now I like more this way :-/ is it that bad compared to the first version?

The design pattern is: https://developer.gnome.org/hig/stable/search.html.en

Sorry to bother you all guys !!!! (ToT)/

[larchunix]

I'm fine with the second screenshot (according to the design pattern, the searchbar hide/unhide button should be on the right and the text should be removed).

[antenore]

Like this should be fine for everybody I think. We just need to fix a weird performance issue.

[larchunix]

Well done!

[giox069]

Very good!

[antenore]

Tested the last @giox069 fixes (thanks!!!).

Everything is fine. I merge this and I'm preparing for a new release.

[Chugajstyr]

Previous Remmina main interface is not available now? Any chance it will be accessible as an option? I get used to it))).

[antenore]

I'm sorry @Chugajstyr but we cannot support two different interfaces.

Unlucky it's not like desktop theme. The modifications we have done are deep in the code.

We discussed these changes between us and openly with the community before to commit them.

Beside usability reasons and beside the fact that we like a lot this new interface , Gnome is clearly taking this direction in terms of layout and as Remmina is (still? yet?) a GTK+ application we have to follow the wave or one day Remmina won't work and/or integrate in a GTK+ environment.

I understand your discomfort and I'm sorry for this, but we cannot do that much.

Please don't hesitate to open new issues or comment to existing ones, when it makes sense we will do our best to support you.

[Chugajstyr]

Its ok, @antenore, Iam appreciate Your work on improving Remmina, it`s features & usabilty. I too much used to this thing in all, to give up because of the lost toolbar))).