Screenshot segfault #841
Merged
Screenshot segfault #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also merged the vte fixes as it was broken since the last GTK+ versions as reported by #835 I don't know yet if it's a good idea to merge this as there is still an important bug to be fixed #842 |
|
I've fixed the CPU issue reported by #842 so if you agree to include this patches I'll merge them, otherwise I'll bisect the last commits and I'll do 2 separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #836, but also makes remmina compliant with GtkApplication object, converting commandline parsing as described in GApplication for GLib 2.40 and above.
Some minor fixes are included for correct screenshot creation.