Added user survey, community links and fixed all deprecations warnings #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now remmina version show something like "1.2.0-rcgit.8 (git 194cc9d)" Having a git commit id helps to identify builds and eases debuggin. The downside is that GetGitRevisionDescription retriggers a cmake re-configuration after each git commit. But thats the only way to get correct version informations without having git hooks or similar. GetGitRevisionDescription is based on Ryan Pavlik cmake Modules and @bmiklautz patch 32390d7 in FreeRDP
antenore
added a commit
that referenced
this pull request
Jan 22, 2016
Added user survey, community links and fixed all deprecations warnings
|
I'm going to merge, but if you have any critics to the code I'll be happy to fix them. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mainly add a user survey dialog that it'll be used to better understand our user base.
We want to collect some basic remmina preferences, like which protocol are used, just to better focus on our development priorities.
None of the collected data will be used for any other purpose (the php source code is available on request)
Beside the survey, I have added and modified our main community links in the Help menu and fixed some different issues like deprecations warnings, code cleaning (glib coding guidelines applied where possible), etc
@akallabeth @giox069