CMake Migration #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little late to it but may I ask what the rationale was for switching to CMake? I was running live builds of Remmina up until the point you switched and I never saw any issues in the way autotools was being utilized. Is it a system the new devs are more comfortable with or was a it a design decision to improve development? |
|
@doctaweeks there's pretty much just me working on this right now, since vic is busy. In the related FreeRDP project we switched from autotools to cmake and we really liked it. It's much simpler and fun to develop with. It also has the ability to generate project files for just about any build system in existence, a very valuable feature. |
jbicha
pushed a commit
to jbicha/Remmina
that referenced
this pull request
Jun 12, 2016
CMake Migration
giox069
added a commit
that referenced
this pull request
Jun 29, 2017
giox069
added a commit
that referenced
this pull request
Sep 25, 2017
giox069
added a commit
that referenced
this pull request
Jan 7, 2018
giox069
added a commit
that referenced
this pull request
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of the build system to cmake.
I have tried my best to replicate what the original build system was doing with cmake. It should be able to provide configurable builds, with proper installation of data files and translations.
The only little glitch left which I am not sure of is building remmina with libssh. The NX plugin can build and load fine with it, but as soon as remmina is built with libssh it will fail to start with an error saying that remmina is linked to both GTK2 and GTK3 libraries at the same time. When trying to identify the culprit I noticed that when libssh was enabled, remmina was linked against libgtk-x11-2.0.so.0, while it wouldn't if libssh was disabled.
The other thing which would be left to check is how to create packages, but that can come later.
If the current cmake migration is stable enough to be merged without affecting too much people, I suggest we go ahead.