Simplify pthreads library detection #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the cmake builtin Threads library detection, and bail out if it wasn't pthreads. This allows deleting the cmake/FindPTHREAD.cmake file which complains because pthreads doesn't provide a pkg-config file. In newer versions of cmake the FindThreads module has the THREADS_PREFER_PTHREAD_FLAG variable and creates a Threads::Threads import target. However, in order top remain compatible with older cmake version this is not used.
|
This is good! I had problems, from time to time, about this error and I was not sure about the root cause. Let us test it on some different distros to be sure we can merge it (I'm quite sure it will be safe). If travis doesn't complains it should be already good |
|
Good. FWIW, I developed and tested this on Ubuntu 16.04 amd64. |
|
Tested, it's fine for me, I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the cmake builtin Threads library detection, and bail out if it
wasn't pthreads. This allows deleting the cmake/FindPTHREAD.cmake file
which complains because pthreads doesn't provide a pkg-config file.
In newer versions of cmake the FindThreads module has the
THREADS_PREFER_PTHREAD_FLAG variable and creates a Threads::Threads
import target. However, in order to remain compatible with older
cmake versions this is not used.
Also, it seems pthreads is used unconditionally in the code, thus don't make it optional in cmakefiles.