Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better button labelling and new save button #1250

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Conversation

antenore
Copy link
Member

@antenore antenore commented Aug 15, 2017

This patch ad a new "Save and Connect" button and improve the labeling of the others.

See issue #1247

@antenore antenore self-assigned this Aug 15, 2017
@antenore
Copy link
Member Author

@giox069 I forgot this in the rcgit-20 :-\

Can I merge into "next"? We'll need another release soon

@giox069 giox069 merged commit e6c7efe into next Aug 27, 2017
@antenore
Copy link
Member Author

Thank you @giox069

@ghost
Copy link

ghost commented Oct 16, 2017

@antenore: I tried the remmina in version 1:1.2.0rcgit.21-1 today, and although I can see the new labeling, the settings are saved no matter if I use the "Connect" or the "Save & Connect" button. My report (#1247) was closed because you wanted to follow up in here but it seems that it is still not resolved in rcgit-21?

@antenore
Copy link
Member Author

Which setting exactly? All? Because @giox069 has fixed some few days ago, after rcgit-21, a bug regarding the resolution not saved.

@antenore antenore deleted the issue1247_defaults branch October 25, 2017 22:04
@ghost
Copy link

ghost commented Nov 2, 2017

Sorry for late reply. When editing a connection and choosing "Connect" button, the settings (e.g. username and screen resolutions) are still saved (basically the purpose of the "Save and Connect" button now). I am fully aware of the commit but my issue #1247 was not solved by it.

@giox069
Copy link
Contributor

giox069 commented Nov 3, 2017

@smilemak are you running remmina 1.2.0-rcgit.24 ?

@ghost
Copy link

ghost commented Nov 5, 2017

@giox069 no still 1.2.0rcgit.22-1. The package is flagged out of date on ARCH so I guess the maintainer will soon update it now. Will reply as soon as tested

@ghost
Copy link

ghost commented Dec 5, 2017

@giox069 checked today with 1:1.2.0rcgit.24-1 which works as it should! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants