Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The host key should not affect subsequent key operations #1132

Merged
merged 5 commits into from
Mar 7, 2017

Conversation

nanxiongchao
Copy link
Contributor

@nanxiongchao nanxiongchao commented Mar 6, 2017

For example, when you use the host key to complete the full-screen mode (ctrl_r + f),
the subsequent key operation has two effects:
Continue to full-screen mode does not need the host key, such as directly
by "f" can be achieved
In the editing interface can not enter other buttons until you press ctrl_r again,
I think this affects the user's experience
I have tested,looks well

No prompt information while another login using the same account FreeRDP#1114
More detailed error messages
Use the function to get the error message instead of the specified string
For example, when you use the host key to complete the full-screen mode (ctrl_r + f),
the subsequent key operation has two effects:
Continue to full-screen mode does not need the host key, such as directly
by "f" can be achieved
In the editing interface can not enter other buttons until you press ctrl_r again,
I think this affects the user's experience
I have tested,looks well
For example, when you use the host key to complete the full-screen mode (ctrl_r + f),
the subsequent key operation has two effects:
Continue to full-screen mode does not need the host key, such as directly
by "f" can be achieved
In the editing interface can not enter other buttons until you press ctrl_r again,
I think this affects the user's experience
I have tested,looks well
@antenore
Copy link
Member

antenore commented Mar 6, 2017

Thank you, we are looking at it.

@antenore
Copy link
Member

antenore commented Mar 6, 2017

Tested, it looks good.
@giox069 I can merge it, ok for you?

@antenore antenore self-assigned this Mar 6, 2017
@antenore antenore requested review from antenore and giox069 March 6, 2017 15:11
Copy link
Member

@antenore antenore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@giox069
Copy link
Contributor

giox069 commented Mar 6, 2017

Looks good for me too.
@nanxiongchao are you able to squash all the commits in a single commit? 5 commits for a single line of code is a bit... "unbalanced" :)

Copy link
Contributor

@giox069 giox069 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@nanxiongchao
Copy link
Contributor Author

@antenore Thanks,it's good news for me

@nanxiongchao
Copy link
Contributor Author

@giox069 Thank you for your reminder that I will continue to study and improve

@antenore antenore merged commit 1d744f6 into FreeRDP:next Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants