Skip to content

Commit

Permalink
Merge pull request #490 from Fitoschido/next
Browse files Browse the repository at this point in the history 
Update Spanish translation
  • Loading branch information
@giox069
giox069 committed Feb 22, 2015
2 parents 06fcfd3 + 85cc2dd commit b8cdaa7
Showing 1 changed file with 79 additions and 83 deletions.
Loading

6 comments on commit b8cdaa7

@muflone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the about dialog accordingly by adding the new translator

@giox069
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muflone: Fixed missing

gtk_about_dialog_set_translator_credits(GTK_ABOUT_DIALOG(dialog), _("translator-credits"));

into remmina_about.c with commit 84c927c

@muflone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wasn't the approach that I was thinking.
At this point all the translators in the remmina_about.glade must be removed as they will be overwritten by the upper line.

@giox069
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not fully aware of translators in remmina_about.glade (despite I had some kind of suspect). But using remmina_about.glade means that

  1. translators cannot update the credits by themselves just editing .po files
  2. for every new translation contribution, someone has to remember to update remmina_about.glade after merging the .po file changes. Will we, and future maintaners, remember to do it ?
  3. there are a lot of translators, and is a bit too hard to import all in remmina_about.glade
    So, in my opinion, leaving translation-credits in .po files is a better choice.
    What do you think ?

@muflone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I agree. Obviously we should reject translations where the last translator removes any previous translator
  2. I agree and I was remembering you to add the new translator to the about dialog
  3. I've already imported them all in the about dialog field on commit f1459d0

Therefore I agree to get rid of the translators in the remmina_about.glade and let use only the translator-credits line.

@giox069
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I also agree with "we should reject translations where the last translator removes any previous translator".
    I will cleanup remmina_about.glade and commit it in few minutes.

Please sign in to comment.