Fix a possible crash when name is missing in a profile file

FreeRDP · Sep 2, 2017 · 8f13dff · 8f13dff
1 parent 09fbe27
commit 8f13dff
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/remmina/src/remmina_applet_menu_item.c b/remmina/src/remmina_applet_menu_item.c
@@ -35,6 +35,7 @@
 
 #include <gtk/gtk.h>
 #include <glib/gi18n.h>
+#include <glib/gprintf.h>
 #include <string.h>
 #include <stdarg.h>
 #include "remmina_applet_menu_item.h"
@@ -108,6 +109,13 @@ GtkWidget* remmina_applet_menu_item_new(RemminaAppletMenuItemType item_type, ...
 		item->ssh_enabled = g_key_file_get_boolean(gkeyfile, "remmina", "ssh_enabled", NULL);
 
 		g_key_file_free(gkeyfile);
+
+		if (item->name == NULL) {
+			g_printf("WARNING: missing name= line in file %s. Skipping.\n", item->filename);
+			va_end(ap);
+			return NULL;
+		}
+
 		break;
 
 	case REMMINA_APPLET_MENU_ITEM_DISCOVERED: