Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic outline of a with Auth filter #1

Closed
wants to merge 5 commits into from
Closed

Conversation

FreeMasen
Copy link
Owner

@FreeMasen FreeMasen commented Feb 17, 2021

This is a very basic outline of what a possible with filter might look like for authorization.

Primarily this is a copy of src/filters/cors.rs modified enough to make authorization work at a somewhat rudimentary level.

A few things that I am not super happy with but do not know the ideal way to solve.

  • Export of the trait Authorizer, this is not something that is done anywhere else in the project so doesn't feel like the right path forward.
  • Whatever structure is setup moving forward should probably be returning a Future instead of a Result, especially not a Result<(), ()>
  • As noted by the CI failures, my understanding of what is required when wrapping isn't as great as it could be.

@FreeMasen FreeMasen changed the title basic outline basic outline of a with Auth filter Feb 17, 2021
@FreeMasen FreeMasen closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant