Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (EPS/PEP/NEP)GetErrorEstimate #223

Merged
merged 4 commits into from
Mar 30, 2022
Merged

add (EPS/PEP/NEP)GetErrorEstimate #223

merged 4 commits into from
Mar 30, 2022

Conversation

aszaboa
Copy link
Contributor

@aszaboa aszaboa commented Mar 30, 2022

No description provided.

Copy link
Member

@prj- prj- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for your contribution. See, C++ is not that hard after all :)
I've made some minor suggestions.

plugin/mpi/SLEPc-code.hpp Outdated Show resolved Hide resolved
plugin/mpi/SLEPc-code.hpp Outdated Show resolved Hide resolved
plugin/mpi/SLEPc-code.hpp Outdated Show resolved Hide resolved
@aszaboa
Copy link
Contributor Author

aszaboa commented Mar 30, 2022

Great, I am glad the code is acceptable. Well, C++ is still extremely weird, but I hope to learn and contribute more.
If the modified FreeFem example is also fine, then I think we can proceed.

@prj-
Copy link
Member

prj- commented Mar 30, 2022

Sure, please apply my suggestions (you should be able to do it directly on your web browser), and then I'll merge this.

@aszaboa
Copy link
Contributor Author

aszaboa commented Mar 30, 2022

Sorry, forgot to do that. I think not we are good to go.

@prj- prj- merged commit 40a28ea into FreeFem:develop Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants