Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve compact colony report #115

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zeitlinger
Copy link
Contributor

@zeitlinger zeitlinger commented Jun 11, 2022

  • show good production in blue (i.e. good) if all required buildings are built (including factories, even if factories are not available yet)
  • show bells and hammers, too - this makes it easier to see
    • if all buildings are built (see above)
    • if there is a production warning for hammers - this should have worked by showing underconsumption for lumber, but this was confusing and didn't work
  • don't show underconsumption anymore - always show the warning on the good being produced
  • it's not a warning anymore if the net production is negative (to make all warnings and alerts actionable)
  • add a new column showing workers that are not working
    • this includes persons and excludes expert soldiers, units that are fortified, improving or already have a destination
  • add a column showing units that are working, but not working in their profession

Future work

  • the warning color is hard to see - I would propose some some yellow (second screenshot), but that's not included in the PR yet
  • similarly, the export color is indistinguishable from the alert color for people with red-green weakness, so I've tried out white (second screenshot)
  • the trade advisor should probably be changed to align with the new logic (good warnings, colors) - it can probably use the same logic under the hood

Note

  • this is a very big PR, partly because I started by extracting methods from the report before making changes
  • I can split the PR into multiple PRs if this helps the review process

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant