Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClientInstance::requestImageFromUrl() #112

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

CreeperG16
Copy link
Contributor

Adds the requestImageFromUrl virtual function to ClientInstance

std::shared_ptr<FileDataRequest> ClientInstance::requestImageFromUrl(const std::string& imageUrl, std::function<void(Bedrock::Http::Status, const Core::Path&, uint64_t)> callback);

@FloppyDolphin57
Copy link

What's the point of adding this if you don't add the class fields to use it lol

@FrederoxDev
Copy link
Owner

Wdym? He's shared him using it in the private discord and seems like he can use it just fine

@FloppyDolphin57
Copy link

Wdym? He's shared him using it in the private discord and seems like he can use it just fine

The pull didn't include the struct of the return value of the function

@FrederoxDev
Copy link
Owner

Ah yeah

Copy link
Owner

@FrederoxDev FrederoxDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conversation

Copy link
Owner

@FrederoxDev FrederoxDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only using the callback right now

@FrederoxDev FrederoxDev merged commit c67e918 into FrederoxDev:1.4.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants