Added FillingContainer class. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added FillingContainer class to be able to work with filling containers (chests/shulker boxes/ender chests) etc
FrederoxDev
reviewed
Jun 23, 2024
| mPlayer(player) | ||
| { | ||
| //workaround to place the original game vtable on the class instance even in a implemented constructor | ||
| *reinterpret_cast<void**>(this) = FillingContainer_vtable; |
There was a problem hiding this comment.
Why is this needed? If you're planning to construct from this, doing asm definitions for this should be good?
There was a problem hiding this comment.
forgot to remove xD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FillingContainer class to be able to work with filling containers (chests/shulker boxes/ender chests) etc