Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowpack): exit process after success #956

Merged
merged 1 commit into from
Aug 28, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions snowpack/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ export async function cli(args: string[]) {

if (cmd === 'add') {
await addCommand(cliFlags['_'][3], commandOptions);
return;
return process.exit(0);
}
if (cmd === 'rm') {
await rmCommand(cliFlags['_'][3], commandOptions);
return;
return process.exit(0);
}

if (cliFlags['_'].length > 3) {
Expand All @@ -105,15 +105,15 @@ export async function cli(args: string[]) {

if (cmd === 'build') {
await buildCommand(commandOptions);
return;
return process.exit(0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one that matters (and has likelihood of spawning subprocesses) -- the others were added for consistency.

}
if (cmd === 'dev') {
await devCommand(commandOptions);
return;
return process.exit(0);
}
if (cmd === 'install' || !cmd) {
await installCommand(commandOptions);
return;
return process.exit(0);
}

logger.error(`Unrecognized command: ${cmd}`);
Expand Down