Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use verbose "mount" configuration in CSA, make public directory static #1894

Merged
merged 5 commits into from
Dec 11, 2020
Merged

Use verbose "mount" configuration in CSA, make public directory static #1894

merged 5 commits into from
Dec 11, 2020

Conversation

FredKSchott
Copy link
Owner

@FredKSchott FredKSchott commented Dec 10, 2020 •
edited
Loading

Changes

  • Make CSA public directory static (no build/transform run on these files, by default)
  • Use more granular mount syntax
  • rename "dist" to "dist" (I've been wanting to do this for a while, entirely subjective but this feels a bit less robotic / more user-friendly for a starter-template)

Testing

  • Covered by existing tests

Docs

  • I don't think we absolutely need to change the React & Svelte templates for this (the end result is really similar) but we may want to if we want to keep the end result an exact match with the CSA templates. @melissamcewen let me know your thoughts. (Update: now that this changes "dist" to "dist", it probably should).

@vercel
Copy link

vercel bot commented Dec 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/b1v4bmzs7
✅ Preview: https://snowpack-git-static-html-fix.pikapkg.vercel.app

@FredKSchott FredKSchott merged commit 21f2137 into main Dec 11, 2020
@FredKSchott FredKSchott deleted the static-html-fix branch December 11, 2020 06:24
FredKSchott added a commit that referenced this pull request Dec 11, 2020
@FredKSchott
complete _dist_ to dist change from #1894
d2a11b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

@melissamcewen melissamcewen Awaiting requested review from melissamcewen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @drwpow