Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes errors in the multi-file building example #1835

Merged

Conversation

Scott-Fischer
Copy link
Contributor

Changes

For anyone following along with the reference/guide docs line-by-line, they would encounter a syntax and reference error in the multi-file building example code.

  1. The syntax error is thrown after the return statement (missing comma).

  2. Once that is fixed, the "codeToCompile" variable is undefined.

This should fix both errors and allow readers to run the example plugin without any errors.

Testing

No tests added because it's a change to the documentation via a markdown file

Docs

No new docs added, just an update to www/_template/guides/plugins.md

@vercel
Copy link

vercel bot commented Dec 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/dz5eozmyn
✅ Preview: https://snowpack-git-fix-plugin-reference-guide.pikapkg.vercel.app

@FredKSchott
Copy link
Owner

ah, great catch. Thanks for finding/fixing!

@FredKSchott FredKSchott merged commit be3ba0a into FredKSchott:main Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants