Improve named export analysis #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/k27ir9ik3 |
FredKSchott
force-pushed
the
improve-named-export-analysis
branch
from
a3f4522
to
d1e506e
Compare
FredKSchott
commented
Nov 18, 2020
| ? cjsAutoDetectExportsRuntime(val) | ||
| : cjsAutoDetectExportsStatic(val); | ||
| ? cjsAutoDetectExportsTrusted(val) | ||
| : cjsAutoDetectExportsUntrusted(val); |
There was a problem hiding this comment.
chose more appropriate names, now that there's a (sandboxed) runtime aspect to our untrusted scanner.
FredKSchott
commented
Nov 18, 2020
| export default cjs;" | ||
| var all = cjs.all; | ||
| export default cjs; | ||
| export { cjs as __moduleExports, all };" |
There was a problem hiding this comment.
unexpected bug fix ftw!
FredKSchott
commented
Nov 18, 2020
| // Uses VM2 to run safely sandbox untrusted code (no access no Node.js primitives, just JS). | ||
| if (isMainEntrypoint && exports.length === 0 && reexports.length === 0) { | ||
| const vm = new VM2({wasm: false, fixAsync: false}); | ||
| exports = Object.keys( |
There was a problem hiding this comment.
what if module.exports isn't an object? || {}?
drwpow
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
parsefunction not existing.Testing
Docs