Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add onFileChanged hook to JS API #1452

Merged
merged 1 commit into from
Oct 30, 2020
Merged

add onFileChanged hook to JS API #1452

merged 1 commit into from
Oct 30, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

  • Svelte team right now runs their own file watcher in @sveltejs/kit
  • The result is that their SSR implementation doesn't get the same "on change" updates as dev
  • By providing this hook, we make sure that all impl. on top of snowpack are consistent

Testing

  • No JS API tests yet.

Docs

  • No JS API docs yet.

@vercel
Copy link

vercel bot commented Oct 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/dxke87w6x
✅ Preview: https://snowpack-git-add-file-watching-to-js-api.pikapkg.vercel.app

@FredKSchott FredKSchott changed the title add file watching to JS API add onFileChanged hook to JS API Oct 30, 2020
@FredKSchott FredKSchott merged commit e5eb3c4 into master Oct 30, 2020
@FredKSchott FredKSchott deleted the add-file-watching-to-js-api branch October 30, 2020 18:07
peterhpchen pushed a commit to peterhpchen/snowpack that referenced this pull request Oct 31, 2020
@FredKSchott @peterhpchen
add file watching to JS API (FredKSchott#1452)
3411a53
@benmccann benmccann mentioned this pull request Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @drwpow