-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize JS API for startServer()
#1344
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/5gqdvkwtn |
d482071
to
ccc3e2a
Compare
ccc3e2a
to
2439889
Compare
2439889
to
1f7334d
Compare
1f7334d
to
620231f
Compare
620231f
to
3ef3616
Compare
3ef3616
to
439de30
Compare
439de30
to
0b27bea
Compare
export {getUrlForFile as unstable__getUrlForFile} from './build/file-urls'; | ||
|
||
/** DEPRECATED: Promoted to startServer() **/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General note: if you make this /** @deprecated Promoted to startServer() **/
then it shows up in the editor with a line through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great tip, thanks!
Changes
startServer()
JS API (no longer__unstable_startServer()
, now covered by semver)startServer()
API had been implemented as JS wrappers around HTTP calls to the dev server. To build a better JS API, we flipped it: the dev server is now an HTTP layer on top of this same exported JS API.New API
Testing
Docs