-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass sass options to plugin #1308
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/l5siw1qfm |
+1 on the concept here, but also this is so relevant to the work we just did with Svelte. The lesson from that was "pass compiler options as a separate config, and not the top-level config". You can see them grappling with this decision 2 years later, here: sveltejs/svelte#1101 (comment) Given that we just made that change for Svelte, lets follow the same pattern here. Instead of supporting all of these on the top -level object and then picking them out, lets instead support them on a single |
dd55f98
to
837513a
Compare
837513a
to
865807f
Compare
60724b4
to
c985a33
Compare
5512339
to
c985a33
Compare
be50c82
to
1364d2c
Compare
1364d2c
to
6b8006b
Compare
Changes
This doesn’t change how the plugin operates at all; just allows the plugin to accept flags Sass would be able to accept normally:
style
sourceMap
sourceMapUrls
embedSources
embedSourceMap
charset
update
While some of these options may be used more than others, it still helps our plugin to feel less like a restriction and more like a boost for Sass users.
Testing
Tests were added!
Docs
Plugin docs updated.