Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error handing #1180

Merged
merged 1 commit into from
Oct 2, 2020
Merged

improve error handing #1180

merged 1 commit into from
Oct 2, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

  • Followup from working with @melissamcewen
  • There were some strange errors uncovered related to invalid JSX in a JS result
  • This work improves those errors

Before

Screen Shot 2020-10-01 at 7 10 45 PM

Screen Shot 2020-10-01 at 7 11 14 PM

(No error overlay shown, just a blank screen)

After

Screen Shot 2020-10-01 at 7 13 23 PM

Screen Shot 2020-10-01 at 7 17 12 PM

Screen Shot 2020-10-01 at 7 14 40 PM

@FredKSchott FredKSchott requested a review from a team as a code owner October 2, 2020 02:18
@vercel
Copy link

vercel bot commented Oct 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/l1vc3jws8
✅ Preview: https://snowpack-git-improve-error-handling.pikapkg.vercel.app

@FredKSchott FredKSchott merged commit a809fcc into master Oct 2, 2020
@FredKSchott FredKSchott deleted the improve-error-handling branch October 2, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissamcewen melissamcewen melissamcewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @melissamcewen