use regex for detecting import.meta (#1371)

* use regex for detecting import.meta * move regex out of hot code path * update snapshot
FredKSchott · Oct 20, 2020 · f14b23b · f14b23b · vercel · Oct 20, 2020
1 parent d18ab79
commit f14b23b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/snowpack/src/build/build-import-proxy.ts b/snowpack/src/build/build-import-proxy.ts
@@ -14,6 +14,8 @@ const SRI_ERROR_HMR_SNOWPACK = generateSRI(
   readFileSync(path.join(__dirname, '../../assets/hmr-error-overlay.js')),
 );
 
+const importMetaRegex = /import\s*\.\s*meta/;
+
 export function getMetaUrlPath(urlPath: string, config: SnowpackConfig): string {
   let {metaDir} = config.buildOptions || {};
   return path.posix.normalize(path.posix.join('/', metaDir, urlPath));
@@ -30,7 +32,7 @@ export function wrapImportMeta({
   env: boolean;
   config: SnowpackConfig;
 }) {
-  if (!code.includes('import.meta')) {
+  if (!importMetaRegex.test(code)) {
     return code;
   }
   return (

diff --git a/test/build/base-url/__snapshots__ b/test/build/base-url/__snapshots__
@@ -77,7 +77,9 @@ export default function doNothing() {
   // I do nothing 🎉
 }
 // Triggers a snowpack meta import URL
-console.log(import.meta.env)"
+console.log(import
+  .meta
+  .env)"
 `;
 
 exports[`snowpack build base-url: build/web_modules/array-flatten.js 1`] = `

diff --git a/test/build/base-url/public/index.js b/test/build/base-url/public/index.js
@@ -7,4 +7,6 @@ export default function doNothing() {
 }
 
 // Triggers a snowpack meta import URL
-console.log(import.meta.env)
+console.log(import
+  .meta
+  .env)